Skip to content

Conversation

@akinross
Copy link
Collaborator

@akinross akinross commented Dec 4, 2023

…_peer module

fixes #513

@akinross akinross force-pushed the 513_bgp_peer_authentication_sr_mpls branch 2 times, most recently from 458a1d4 to 38530b3 Compare December 4, 2023 18:47
@akinross akinross force-pushed the 513_bgp_peer_authentication_sr_mpls branch from 38530b3 to 74a3d43 Compare December 4, 2023 18:57
@codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (0e7af57) 96.30% compared to head (74a3d43) 35.23%.

Files Patch % Lines
plugins/modules/aci_l3out_bgp_peer.py 0.00% 30 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #543       +/-   ##
===========================================
- Coverage   96.30%   35.23%   -61.07%     
===========================================
  Files         211      211               
  Lines        9748     9771       +23     
  Branches     1456     1462        +6     
===========================================
- Hits         9388     3443     -5945     
- Misses        276     6328     +6052     
+ Partials       84        0       -84     
Flag Coverage Δ
integration ?
sanity 35.23% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akinross
Copy link
Collaborator Author

akinross commented Dec 4, 2023

This PR is depending on #542 and should be merged after. Cherry pick the commit in case you want to run tests.

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 7ad2b51 into CiscoDevNet:master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cisco.aci.aci_l3out_bgp_peer has not property for BGP Authentication

5 participants