Add auto to link level speed options #577

edudppaz · 2024-01-10T12:38:13Z

"auto" for the link level policy is missing from the choices in the ansible module. This adds the "auto" option to allow an auto negotiating interface speed to be configured on the APIC controller

akinross

thank you for the contribution, see few comments that I believe would need to be added

plugins/modules/aci_interface_policy_link_level.py

edudppaz · 2024-01-12T09:31:52Z

@akinross i have updated the documentation and added the new integration tests. i tried to run the whole test playbook to verify, but im getting throttled by the Cisco sandbox APIC API, and its not possible to change to certificate-based authentication. I could at least get some snippets from it:

Running aci_interface_policy_link_level integration test role

PLAY [aci] *********************************************************************

TASK [aci_interface_policy_link_level : Test that we have an ACI APIC host, ACI username and ACI password] ***
skipping: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Verify Cloud and Non-Cloud Sites in use.] ***
included: /Users/edpozo/Git/AIB/ansible_collections/cisco/aci/tests/integration/targets/aci_cloud_provider/tasks/main.yml for sandboxapicdc.cisco.com

TASK [aci_interface_policy_link_level : Test that we have an ACI APIC host, ACI username and ACI password] ***
skipping: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Set vars] ******************************
ok: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Query system information] **************
[WARNING]: Platform darwin on host sandboxapicdc.cisco.com is using the
discovered Python interpreter at /opt/homebrew/bin/python3.11, but future
installation of another Python interpreter could change the meaning of that
path. See https://docs.ansible.com/ansible-
core/2.15/reference_appendices/interpreter_discovery.html for more information.
ok: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Query cloud provider object] ***********
ok: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Set vars] ******************************
skipping: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Verify query_cloud for all sites] ******
ok: [sandboxapicdc.cisco.com] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [aci_interface_policy_link_level : Verify query_cloud for Cloud Sites] ****
skipping: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Remove Link Level Policy] **************
changed: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Add Link Level Policy (check mode)] ****
changed: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Add Link Level Policy (normal mode)] ***
changed: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Verify Add Link Level Policy] **********
ok: [sandboxapicdc.cisco.com] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [aci_interface_policy_link_level : Add Link Level Policy again (check mode)] ***
ok: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Add Link Level Policy again (normal mode)] ***
ok: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Verify Add Link Level Policy again] ****
ok: [sandboxapicdc.cisco.com] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [aci_interface_policy_link_level : Change description of Link Level Policy (check mode)] ***
changed: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Change description of Link Level Policy (normal mode)] ***
changed: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Verify add_policy_descr] ***************
ok: [sandboxapicdc.cisco.com] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [aci_interface_policy_link_level : Change description of Link Level Policy again (check mode)] ***
ok: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Change description of Link Level Policy again (normal mode)] ***
ok: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Verify add_policy_descr_again] *********
ok: [sandboxapicdc.cisco.com] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [aci_interface_policy_link_level : Add Link Level Policy again with no description (check mode)] ***
ok: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Add Link Level Policy again with no description (normal mode)] ***
ok: [sandboxapicdc.cisco.com]

TASK [aci_interface_policy_link_level : Verify add_policy_again_no_descr] ******
ok: [sandboxapicdc.cisco.com] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [aci_interface_policy_link_level : Add Link Level Policy with various speeds (check mode)] ***
changed: [sandboxapicdc.cisco.com] => (item=speed-100M)
changed: [sandboxapicdc.cisco.com] => (item=speed-1G)
changed: [sandboxapicdc.cisco.com] => (item=speed-10G)
changed: [sandboxapicdc.cisco.com] => (item=speed-25G)
changed: [sandboxapicdc.cisco.com] => (item=speed-40G)
changed: [sandboxapicdc.cisco.com] => (item=speed-50G)
changed: [sandboxapicdc.cisco.com] => (item=speed-100G)
changed: [sandboxapicdc.cisco.com] => (item=speed-200G)
changed: [sandboxapicdc.cisco.com] => (item=speed-400G)
changed: [sandboxapicdc.cisco.com] => (item=speed-auto)
ok: [sandboxapicdc.cisco.com] => (item=speed-inherit)

TASK [aci_interface_policy_link_level : Add Link Level Policy with various speeds (normal mode)] ***
changed: [sandboxapicdc.cisco.com] => (item=speed-100M)
changed: [sandboxapicdc.cisco.com] => (item=speed-1G)
changed: [sandboxapicdc.cisco.com] => (item=speed-10G)
changed: [sandboxapicdc.cisco.com] => (item=speed-25G)
changed: [sandboxapicdc.cisco.com] => (item=speed-40G)
changed: [sandboxapicdc.cisco.com] => (item=speed-50G)

edudppaz · 2024-01-12T09:38:16Z

Got the whole tests running.

PLAY RECAP *********************************************************************
sandboxapicdc.cisco.com    : ok=43   changed=9    unreachable=0    failed=0    skipped=4    rescued=0    ignored=2

akinross

i will run tests locally when you have changed the assert for checkmode

tests/integration/targets/aci_interface_policy_link_level/tasks/main.yml

…s/main.yml Co-authored-by: Akini Ross <akinross@cisco.com>

akinross

see comment response

tests/integration/targets/aci_interface_policy_link_level/tasks/main.yml

akinross

LGTM

shrsr

LGTM

plugins/modules/aci_interface_policy_link_level.py

Co-authored-by: Samita B <98932546+samiib@users.noreply.github.com>

akinross

LGTM

shrsr

LGTM

codecov · 2024-01-16T21:09:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (647dc30) 96.26% compared to head (666be5e) 35.20%.
Report is 6 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #577       +/-   ##
===========================================
- Coverage   96.26%   35.20%   -61.06%     
===========================================
  Files         231      231               
  Lines       10647    10663       +16     
  Branches     1603     1607        +4     
===========================================
- Hits        10249     3754     -6495     
- Misses        305     6909     +6604     
+ Partials       93        0       -93

Flag	Coverage Δ
integration	`?`
sanity	`35.20% <ø> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

samiib

LGTM

plugins/modules/aci_interface_policy_link_level.py

Co-authored-by: Lionel Hercot <lionel.hercot@gmail.com>

akinross

LGTM

shrsr

LGTM

samiib

LGTM

lhercot

LGTM

lhercot · 2024-01-17T23:33:35Z

Thanks for your contribution!

Add auto to link level speed options

1293a07

edudppaz mentioned this pull request Jan 10, 2024

Add auto to link level speed options (aci_interface_policy_link_level) #576

Closed

akinross requested changes Jan 10, 2024

View reviewed changes

plugins/modules/aci_interface_policy_link_level.py Show resolved Hide resolved

akinross requested review from anvitha-jain, gmicol, sajagana, samiib and shrsr January 10, 2024 12:47

akinross linked an issue Jan 10, 2024 that may be closed by this pull request

Add auto to link level speed options (aci_interface_policy_link_level) #576

Closed

edudppaz added 3 commits January 11, 2024 09:06

Update doc with new choice

731de86

New integration test for speeds

2f089d4

Using block, loop labels and quiet asser to avoid so verbose output

249fd27

edudppaz requested a review from akinross January 12, 2024 09:32

Speed item typo

e9f4b25

akinross requested changes Jan 12, 2024

View reviewed changes

tests/integration/targets/aci_interface_policy_link_level/tasks/main.yml Show resolved Hide resolved

Check mode assert

5a6d28c

edudppaz requested a review from akinross January 12, 2024 10:01

akinross requested changes Jan 12, 2024

View reviewed changes

edudppaz and others added 2 commits January 12, 2024 13:32

Update tests/integration/targets/aci_interface_policy_link_level/task…

85ab638

…s/main.yml Co-authored-by: Akini Ross <akinross@cisco.com>

<5.2 and >= 5.2 tests, new format

7e2b6bf

edudppaz requested a review from akinross January 15, 2024 09:04

akinross reviewed Jan 15, 2024

View reviewed changes

Moving system info ACI to general task

b5a8e57

akinross requested changes Jan 15, 2024

View reviewed changes

tests/integration/targets/aci_interface_policy_link_level/tasks/main.yml Outdated Show resolved Hide resolved

Remove forgotten debug ignore

5830de2

akinross self-requested a review January 15, 2024 17:20

akinross previously approved these changes Jan 15, 2024

View reviewed changes

shrsr previously approved these changes Jan 15, 2024

View reviewed changes

samiib requested changes Jan 16, 2024

View reviewed changes

plugins/modules/aci_interface_policy_link_level.py Outdated Show resolved Hide resolved

Update plugins/modules/aci_interface_policy_link_level.py

4b08e2a

Co-authored-by: Samita B <98932546+samiib@users.noreply.github.com>

edudppaz dismissed stale reviews from shrsr and akinross via 4b08e2a January 16, 2024 14:36

edudppaz requested a review from samiib January 16, 2024 14:37

akinross previously approved these changes Jan 16, 2024

View reviewed changes

shrsr previously approved these changes Jan 16, 2024

View reviewed changes

samiib previously approved these changes Jan 17, 2024

View reviewed changes

lhercot requested changes Jan 17, 2024

View reviewed changes

plugins/modules/aci_interface_policy_link_level.py Outdated Show resolved Hide resolved

Update plugins/modules/aci_interface_policy_link_level.py

666be5e

Co-authored-by: Lionel Hercot <lionel.hercot@gmail.com>

edudppaz dismissed stale reviews from samiib, shrsr, and akinross via 666be5e January 17, 2024 09:25

akinross requested review from akinross, lhercot, samiib and shrsr January 17, 2024 09:48

akinross approved these changes Jan 17, 2024

View reviewed changes

shrsr approved these changes Jan 17, 2024

View reviewed changes

samiib approved these changes Jan 17, 2024

View reviewed changes

lhercot approved these changes Jan 17, 2024

View reviewed changes

lhercot merged commit a2c6f62 into CiscoDevNet:master Jan 17, 2024

Add auto to link level speed options #577

Add auto to link level speed options #577

Uh oh!

Conversation

edudppaz commented Jan 10, 2024

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

edudppaz commented Jan 12, 2024

Uh oh!

edudppaz commented Jan 12, 2024

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

shrsr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

shrsr left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

samiib left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

shrsr left a comment

Choose a reason for hiding this comment

Uh oh!

samiib left a comment

Choose a reason for hiding this comment

Uh oh!

lhercot left a comment

Choose a reason for hiding this comment

Uh oh!

lhercot commented Jan 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jan 16, 2024 •

edited

Loading