Skip to content

[minor_change] Added Playbook Optimizing documentation #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2024
Merged

[minor_change] Added Playbook Optimizing documentation #641

merged 3 commits into from
Apr 17, 2024

Conversation

@samiib
Copy link
Collaborator

@samiib samiib commented Apr 11, 2024

  • Added ACI HTTPAPI documentation
  • Added suppress_previous and suppress_verification documentation

@samiib samiib self-assigned this Apr 11, 2024
@samiib samiib added the documentation Improvements or additions to documentation label Apr 11, 2024
@samiib samiib linked an issue Apr 11, 2024 that may be closed by this pull request
Performance evaluation and recommendation for improvement #609
Closed
akinross
akinross requested changes Apr 11, 2024
View reviewed changes
@akinross
Copy link
Collaborator

akinross commented Apr 11, 2024

failing sanity checks

@samiib
[minor_change] Added Playbook Optimizing documentation
22e69bb 
- Added ACI HTTPAPI documentation
- Added suppress_previous and suppress_verification documentation
@samiib samiib force-pushed the 605_performance_readme branch from 0fff6d9 to 22e69bb Compare April 11, 2024 09:10
@akinross akinross self-requested a review April 12, 2024 02:41
akinross
akinross previously approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiib samiib force-pushed the 605_performance_readme branch from 711e087 to f7d3171 Compare April 12, 2024 03:11
@samiib samiib requested a review from akinross April 12, 2024 03:11
akinross
akinross previously approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr requested changes Apr 12, 2024
View reviewed changes
@samiib samiib requested review from akinross and shrsr April 14, 2024 22:35
akinross
akinross approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lhercot
lhercot approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit ef1e466 into CiscoDevNet:master Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhercot lhercot lhercot approved these changes

@shrsr shrsr shrsr approved these changes

@akinross akinross akinross approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@sajagana sajagana sajagana approved these changes

@gmicol gmicol gmicol approved these changes

Assignees

@samiib samiib

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Performance evaluation and recommendation for improvement

7 participants

@samiib @akinross @lhercot @shrsr @anvitha-jain @sajagana @gmicol