Skip to content

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • move the reload key logic out of GroovyScript.java.
  • add add logic to add new keys, supporting both keyboard and mouse both inside and outside a gui.
  • enable keys by default only if debug is enabled. note that a single launch sets the options.txt and these will always be loaded.
  • add a copy keybind (default: ctrl+c) to copy the hovered itemstack if in an inventory (inc. jei), or the held itemstack/thing being looked at/yourself if not.
  • extract the raytracing code for the Info Commands to a general RayTracingHelper.java.
  • improve InfoParserPackage logic with setStack now also setting the block instead of doing that every time it was called, and firing the event when calling parse instead of again needing the external places to call it.

currently, if you launch with debug disabled, even its enabled on a later launch you will need to rebind these keys. however, doing this means that a pack shipped with debug disabled will not have these keybinds assigned. i am unsure if this is a good idea, as it seems like debug defaults to false.

@WaitingIdly WaitingIdly added enhancement New feature or request refactor Something is rewritten labels Oct 6, 2025
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug thing is not optimal

@brachy84 brachy84 merged commit a988294 into CleanroomMC:master Oct 9, 2025
@WaitingIdly WaitingIdly deleted the adjust-keybinds branch October 9, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor Something is rewritten

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants