Skip to content

Conversation

@WaitingIdly
Copy link
Collaborator

what this PR adds:

  • compat with Extended Crafting Compression crafting (crafttweaker level, consume catalyst)
  • compat with Extended Crafting Combination crafting (crafttweaker level)
  • compat with Extended Crafting Ender Crafting crafting (crafttweaker level, shapeless crafts, mirrored shaped crafts, key matrix)
  • compat with Extended Crafting Table Crafting crafting (basic crafting, tier selection, shapeless/shaped/mirrored, key matrix)
  • any of the above compats which have a config value for a default value respects that config
  • a NonNullList conversion to IngredientHelper, and updated blood magic compat to use it
  • an override in IIngredient for withStack

currently not implemented:

  • recipe transformers for Ender Crafting (might not work regardless) and Table Crafting (part of the crafttweaker
  • ability to use null in ingredient matrices, eg
mods.extendedcrafting.endercrafting.shapedBuilder()
        .output(item('minecraft:diamond') * 32)
        .matrix([[item('minecraft:gold_ingot'),null,item('minecraft:gold_ingot')],
                [null,item('minecraft:gold_ingot'),null],
                [item('minecraft:gold_ingot'),null,item('minecraft:gold_ingot')]])
        .time(1)
        .register()

@brachy84
Copy link
Member

I impoved recipe matching by implementing our own recipe class which just wraps a crafting recipe since the matching logic is exactly the same. Now stuff like transformers and match conditions should also work.
I also implemented that the recipe maker item will now generate groovy code instead of zs via mixin.

@brachy84 brachy84 merged commit 4c59a23 into CleanroomMC:master Apr 12, 2023
@WaitingIdly WaitingIdly deleted the extended-crafting branch July 2, 2023 15:34
@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod compat Relating to compatability with a mod or features of a mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants