Botania Support #54
Merged
Botania Support #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rongmario
requested changes
May 16, 2023
Member
Rongmario
left a comment
Rongmario
left a comment
There was a problem hiding this comment.
Just a few things and an example script file and it'll be ready.
Comment on lines
22
to
26
| if (subClass.getSimpleName().equals("Mini") && SubTileEntity.class.isAssignableFrom(subClass)) { | ||
| BotaniaAPI.registerMiniSubTile(name + "Chibi", (Class<? extends SubTileEntity>) subClass, name); | ||
| BotaniaAPI.registerSubTileSignature((Class<? extends SubTileEntity>) subClass, new BasicSignature(name + "Chibi")); | ||
| BotaniaAPI.addSubTileToCreativeMenu(name); | ||
| break; |
Member
There was a problem hiding this comment.
This was some scuffed requirement in Botania's internal registration, perhaps make this more clearer and explicit?
src/main/java/com/cleanroommc/groovyscript/core/mixin/botania/PageCraftingRecipeMixin.java
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/botania/recipe/OrechidRecipe.java
Outdated
Show resolved
Hide resolved
Rongmario
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Botania.
Adds recipes additon/removal for:
Adds support for adding/removing blocks and items from the magnet blacklist.
Adds convenience methods for registering custom flowers.
Adds support for adding custom brews.
Adds support for adding custom knowledge types.
Adds support for adding/removing lexicon categories.
Adds support for adding/removing lexicon entries.
Adds support for adding/removing lexicon pages.