Add String based alternatives to builders that use Aspects #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaitingIdly
requested changes
Jun 18, 2023
Collaborator
WaitingIdly
left a comment
WaitingIdly
left a comment
There was a problem hiding this comment.
could you add these new options to the example file?
WaitingIdly
approved these changes
Jun 19, 2023
brachy84
requested changes
Jun 23, 2023
Member
brachy84
left a comment
brachy84
left a comment
There was a problem hiding this comment.
Unlike the aspect bracket handler, this doesnt do any validation if the aspect really exists.
Member
|
Now you completely changed the aspect bracket handler. An exception should only be thrown if there's an invalid amount of arguments or if the arguments have the wrong type. Otherwise it should return null. The bracket handler will then automatically handle the error message. |
brachy84
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to use
.aspect("aer", 5)instead of.aspect(aspect("aer") * 5)for convenience.