Run PostInit scripts on LoadComplete #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I would like this to be consistent with pre init loading. See LoaderControllerMixin. |
brachy84
reviewed
Jun 24, 2023
src/main/java/com/cleanroommc/groovyscript/core/mixin/LoaderControllerMixin.java
Outdated
Show resolved
Hide resolved
brachy84
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the
POST_INITloader onFMLLoadCompleteinstead ofFMLPostInitialization. (while making sure run before JEI loads)This solves any issues with scripts being run before a mod loads required recipes or other things, including an existing issue where Tinkers' registers melting recipes after scripts are run.
Also added logs that say how long the first script loads took.