Apply class transformers to classes loaded by groovy #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaitingIdly
approved these changes
Aug 3, 2023
Collaborator
WaitingIdly
left a comment
WaitingIdly
left a comment
There was a problem hiding this comment.
didnt explode the scripts i tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 4, groovy decompiles the classes itself via asm and is no longer a bunch of reflection magic.
Class formers where not properly (or not at all) applied to classes loaded by groovy. This PR fixes that.
Meaning groovy will now respect
@SideOnlyannotations. But it does not work in all cases. When a method was removed on server side because it's client annotated and the method is abstract in super class which does not have the annotation, then groovy crashes.