Lootscript #95
Merged
Lootscript #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 20, 2023 21:42
…into lootscript # Conflicts: # src/main/java/com/cleanroommc/groovyscript/event/EventHandler.java # src/main/java/com/cleanroommc/groovyscript/gameobjects/GameObjectHandlers.java
brachy84
reviewed
Nov 21, 2023
src/main/java/com/cleanroommc/groovyscript/registry/ReloadableRegistryManager.java
Outdated
Show resolved
Hide resolved
brachy84
requested changes
Nov 21, 2023
src/main/java/com/cleanroommc/groovyscript/gameobjects/GameObjectHandlers.java
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/loot/Loot.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/loot/GroovyLootFunction.java
Outdated
Show resolved
Hide resolved
brachy84
approved these changes
Nov 26, 2023
Member
brachy84
left a comment
brachy84
left a comment
There was a problem hiding this comment.
Im still not happy about the closure param txpes situation, but well figure that out in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for loot compat not reloading as well as conflicts with other mods.