Fix kill method (GentleKillingExecutor)#72
Conversation
There was a problem hiding this comment.
Prefer importing separate items, especially, that we use only two items out of a whole module.
|
I like random fails. |
There was a problem hiding this comment.
would that require to change default mirakuru version?
Use os.killpg to terminate process (GentleKillingExecutor)
There was a problem hiding this comment.
It will have fail. We have to wait for new version of mirakuru.
There was a problem hiding this comment.
http://stackoverflow.com/questions/4789837/how-to-terminate-a-python-subprocess-launched-with-shell-true
for killing all of child processes you should also add preexec_fn=os.setsid to Popen
There was a problem hiding this comment.
0.2 version mirakuru will do that.
Update requires (mirakuru to 0.2)
|
👍 |
Fix kill method (GentleKillingExecutor)
|
It's not related. We had the random fails before. |
|
It's related to this: Grzegorz Śliwiński 2014-08-14 13:12 GMT+02:00 Tomek Święcicki notifications@github.com:
|
4 participants
No description provided.