This repository was archived by the owner on Sep 18, 2018. It is now read-only.
random ports feature#86
Closed
pwilczynskiclearcode wants to merge 1 commit intodbfixtures:masterfrom
pwilczynskiclearcode:master
Closed
random ports feature#86pwilczynskiclearcode wants to merge 1 commit intodbfixtures:masterfrom pwilczynskiclearcode:master
pwilczynskiclearcode wants to merge 1 commit intodbfixtures:masterfrom
pwilczynskiclearcode:master
Conversation
Author
|
@fizyk @tomislater Could you review? |
pwilczynskiclearcode
changed the title
Author
There was a problem hiding this comment.
Sttrange fact - it never used host/port from arguments
pytest_dbfixtures/port.py
Outdated
Contributor
There was a problem hiding this comment.
I do not get it ;p Is it checks if ports is string which is mapping into int, right? So, we do not need 50 and 51 lines. This try is enough.
Author
There was a problem hiding this comment.
You're completely right
Adds a possibility of passing '?' in port= argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.