Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cities in world not generating on default settings. #70062

Closed
FellsHollow opened this issue Dec 7, 2023 · 20 comments
Closed

Cities in world not generating on default settings. #70062

FellsHollow opened this issue Dec 7, 2023 · 20 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@FellsHollow
Copy link

Describe the bug

I was driving around for a long time and realized that I hadn't seen any cities generating in a long time.

Attach save file

Hildreth-trimmed.tar.gz

Steps to reproduce

  1. Log into game
  2. Drive around
  3. Note cities not generating, some structures, but not cities.

Expected behavior

I updated to latest experimental (see below) and logged in and started driving around. I expected cities to spawn, labs, science labs, etc, but nothing like that did after driving for a loooooong time.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.3693 (22H2)
  • Game Version: f971570 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    Stats Through Skills [StatsThroughSkills]
    ]

Additional context

This happened after updating to the latest experimental from 12.7.2023.
@FellsHollow FellsHollow added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Dec 7, 2023
@Termineitor244
Copy link
Contributor

How much is "driving around for a long time"? And in what direction? Is this an old save? There is a new mechanic in map generation in the game that was merged very recently, where how much you travel in a certain direction affects what you can see, if you travel towards what would be the Atlantic US coast then you see more and more mega cities, and less and less wildness like forests and the like, while on the contrary if you travel towards the (relatively) uninhibited center of the country the cities and towns are smaller and farther between them.

@db48x
Copy link
Contributor

db48x commented Dec 8, 2023

Your bug report might be improved with a screenshot too.

@FellsHollow
Copy link
Author

FellsHollow commented Dec 8, 2023 via email

@Standing-Storm
Copy link
Contributor

#69912 made it so forests get more and more common the further north you go. If you usually drive north, you might have already been north of the 0,0 overmap, meaning that if you updated further mapgen would have immediately been mostly forest.

@FellsHollow
Copy link
Author

FellsHollow commented Dec 8, 2023 via email

@Standing-Storm
Copy link
Contributor

If you travel east, you should gradually get more and more city (at least, east of the original spawn point overmap). I'm not sure what happens in the south.

@esotericist
Copy link
Contributor

if you've been going north, you probably want east AND south. both will increase city size and frequency relative to 'a fair bit north of start'.

ideal would be going back to your world start, then going east or south.

@FellsHollow
Copy link
Author

FellsHollow commented Dec 8, 2023 via email

@I-am-Erk
Copy link
Member

I-am-Erk commented Dec 8, 2023 •
edited
Loading

You can also go into global_settings.json and turn the new settings off or down.

Edit: also I strongly advise against updating an active save game without carefully reading the changelog ;)

@CoroNaut
Copy link

CoroNaut commented Dec 8, 2023 •
edited
Loading

You could also go back to an update before the change. All future updates will contain this major mapgen change unless something happens and it gets reverted.

Is it actually "data/core/game_balance.json"? https://github.com/CleverRaven/Cataclysm-DDA/pull/70002/files#diff-b763acfd01b35aab06c977e0bb0f3dc7f16a5ed58bac5a4206dbfff8e97855ea
I believe the specific values to turn off the forestry would be "OVERMAP_FOREST_INCREASE_....." to 0. Alternatively, setting "OVERMAP_FOREST_LIMIT" to 0 may also work. Also set all "OVERMAP_URBAN_INCREASE_....." to 0 perhaps?

It will be updated from time to time and each update will require you to change the settings here again, unless you're fine with that. Staying on an release before the update is an option too.

@db48x
Copy link
Contributor

db48x commented Dec 8, 2023

I'm extremely far away from where I started the game world. To do that now would take months of real time.

Now I am really curious. What does the map look like up there? What coordinates does it say on the map? Can autodrive really not drive you back to the start?

@FellsHollow
Copy link
Author

FellsHollow commented Dec 8, 2023 via email

@db48x
Copy link
Contributor

db48x commented Dec 8, 2023

Wow, ok; 884.997 miles. Maybe fly instead.

@FellsHollow
Copy link
Author

FellsHollow commented Dec 8, 2023 via email

@db48x
Copy link
Contributor

db48x commented Dec 8, 2023

Depends on how many zombies you left standing in the middle of the road, I imagine. I’m guessing more than a few.

@db48x
Copy link
Contributor

db48x commented Dec 8, 2023

I would just drive south east then. Urbanity should still increase slowly until you hit the ocean, even if it never gets to megacity levels.

@db48x
Copy link
Contributor

db48x commented Dec 8, 2023

Just in case anyone else is curious to know what the far north looks like, where the forestosity is high:

Screenshot from 2023-12-08 12-26-15

@I-am-Erk
Copy link
Member

I-am-Erk commented Dec 8, 2023

You don't need to drive back to center. Listen to me, I programmed this. Go into data/core/global_settings.json and search for the word "FOREST", find the settings that set forest to increase in certain directions and set them to 0.0

@I-am-Erk
Copy link
Member

I-am-Erk commented Dec 8, 2023

I'll tell you the exact fields to edit in a moment

@I-am-Erk
Copy link
Member

I-am-Erk commented Dec 8, 2023

OK I'm at a keyboard. Listen, go to game_balance.json as I said above and edit:

  {
    "type": "EXTERNAL_OPTION",
    "name": "OVERMAP_FOREST_INCREASE_NORTH",
    "info": "Rate at which forest coverage of the map increases to the North, based on regional map settings thresholds.  0=no increase.",
    "stype": "float",
    "value": 0.04
  },
  {
    "type": "EXTERNAL_OPTION",
    "name": "OVERMAP_FOREST_INCREASE_EAST",
    "info": "Rate at which forest coverage of the map increases to the East.  0=no increase.",
    "stype": "float",
    "value": 0
  },
  {
    "type": "EXTERNAL_OPTION",
    "name": "OVERMAP_FOREST_INCREASE_WEST",
    "info": "Rate at which forest coverage of the map increases to the West.  0=no increase.",
    "stype": "float",
    "value": 0.02
  },

in this section set the value to 0 and you'll no longer see high-forest maps at all. Or, set

{
  "type": "EXTERNAL_OPTION",
  "name": "OVERMAP_FOREST_LIMIT",
  "info": "Caps how high the forest threshold can rise.  No cities form at values over 0.4",
  "stype": "float",
  "value": 0.395
},

you could set that to 0.2, which will keep forests exacltly as they were as well.

I'm going to close this issue now, because this isn't a bug, and I ask that other folks please not confuse the poor fellow any further.

Fellshollow, since I think you missed my previous post, I strongly recommend you do not update your game with an active save in it at all, but definitely don't do it without reading the changelog first.

@I-am-Erk I-am-Erk closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@db48x @esotericist @CoroNaut @I-am-Erk @Termineitor244 @FellsHollow @Standing-Storm