-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openable windows without curtains #13877
Conversation
@@ -461,7 +461,7 @@ | |||
[ [ "glass_sheet", 1 ] ] | |||
], | |||
"pre_terrain" : "t_window_empty", | |||
"post_terrain" : "t_window" | |||
"post_terrain" : "t_window_no_curtains" | |||
},{ | |||
"type" : "construction", | |||
"description" : "Build Window", "//": "Step 3: window with curtains", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this one should even stay, you won't be able to build t_window just find them in stores.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution to the store window being special!
There are a few mapgens of houses that should probably use the new windows. data/json/mapgen/house_quiverfull.json comes to mind, it currently has only standard "t_window" (without curtains), which looks a bit strange for a private building. |
I can fix those houses if someone points me to them but otherwise "fixing" houses is not really in the scope of this pr. As for house_quiverfull should it be t_window_domestic or was it intended for the windows to have no curtains and use t_window_no_curtains? |
"difficulty" : 2, | ||
"time" : 30, | ||
"qualities": [ [ | ||
{ "id": "SAW_W", "level": 1 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably have HAMMERING 2 too, to drive the nails in.
This new window needs some different name and preferably either color or glyph too. |
I though it was intended to be windows without curtains. A private house that has windows that can not be opened looks strange to me, but that may be intended. @jokermatt999 (the creator) should know. |
Nope, just a mistake. I've been meaning to get back into developing, so
|
So, I'll leave the house_quiverfull to jokermatt999 then. Recolored domestic windows: |
Openable windows without curtains
I never thought they'd get used! |
It's not pretty, but it gets the job done.
Closes #13858
Closes #7749
Fixes #8165