Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make free functions static to suppress missing declarations errors #30800

Merged

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Fixes #30796.

Describe the solution

Make free functions static to suppress missing declarations errors

@ZhilkinSerg ZhilkinSerg added Code: Build Issues regarding different builds and build environments [C++] Changes (can be) made in C++. Previously named `Code` labels May 24, 2019
@ZhilkinSerg ZhilkinSerg merged commit d1a2d23 into CleverRaven:master May 24, 2019
@ZhilkinSerg
Copy link
Contributor Author

Self merging - let's see if it would fix the builds on Jenkins (not possible to check anywhere on CI - josn linte isn't compiled there).

@ZhilkinSerg ZhilkinSerg deleted the fix-missing-declaration-errors branch May 24, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jenkins builds aren't uploaded to the releases page anymore
1 participant