Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference books #33730

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Conversation

tenmillimaster
Copy link
Member

Summary

SUMMARY: Content "Adds reference books"

Purpose of change

Some recipes would require information that likely cannot be memorized and wouldn't be located in common textbooks.

Describe the solution

I've added a couple of works that I don't think one would really be able to learn from, but would be invaluable in specific recipes.

Want to know what solvent to attempt re-crystallization with? Use the CRC/merck manual.

Want to know whether your patient should/shouldn't take a certain drug with another drug or something? Use the PDR.

Want to know whether you can get decent welds with an arc welder using x base metal and y filler rod? Use the Machinery handbook.

Want to know how to use a certian IC circuit you just pulled out of radio? Why, you'd want to use the datasheet archives. (Thanks whoever scraped them from the internet!)

So on and so forth.

@ghost
Copy link

ghost commented Sep 1, 2019

Will these be required in recipes soon enough?

@tenmillimaster
Copy link
Member Author

I have some stuff planned, but it depends on when I get around to it

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Sep 2, 2019
tenmillimaster and others added 2 commits September 2, 2019 04:41
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
@kevingranade kevingranade merged commit b149e2e into CleverRaven:master Sep 4, 2019
@Rivet-the-Zombie
Copy link
Member

So these don't actually do anything?

@vhzod
Copy link

vhzod commented Sep 4, 2019

Wouldn't most of the existing books have at least some reference information in them already, for example say the chemistry textbook. Perhaps books could have a 1-3 reference property for a given skill with the threes being standalone for very complex procedures or something.

@tenmillimaster
Copy link
Member Author

@rivet

Not yet. This is for higher order crafting. If you'd like to do a double displacement reaction, you're going to need to know relative solubilities: chemistry textbooks simply are not large enough.

if you'd like to confirm a melting point for purity, you will need a Merck handbook.

If you want to know which solvents are appropriate for your liquid liquid extraction of a chemical from a common store bought product, you will need this book.

If you're distilling something much more unique than ethanol, like, say, fractionating gasoline into it's subcomponents, you will want to know the boiling point of each constituent.

These books sole purpose is to replace the information that used to be contained on the internet.

@Rivet-the-Zombie
Copy link
Member

@tenmillimaster, those are great ideas! I'd just kinda rather they had been (at least partially) implemented before this PR was complete.

@tenmillimaster tenmillimaster deleted the Reference-texts branch September 4, 2019 18:42
@tenmillimaster
Copy link
Member Author

tenmillimaster commented Sep 4, 2019

@tenmillimaster, those are great ideas! I'd just kinda rather they had been (at least partially) implemented before this PR was complete.

If I try to do them as 1 PR, I'll get far too OCD about it, get burnt out on expanding scope creep, and take a break again for a while, which I don't want.

misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
* Reference books and spawns
@l29ah
Copy link
Contributor

l29ah commented Feb 25, 2020

OCD got serious it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants