New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fire station basecamp #34181
Add fire station basecamp #34181
Conversation
I think I got them all (except beds)
It's awesome. Some suggestions:
|
and skylights
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency. Please tidy up blueprint_name
in all recipes - in some places it's full sentence, in other it's only just a name of location. Also consistency for upper case and lower case.
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
thanks, no more periods in names : ) Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Fixed the periods. I'll review their structure this evening. Sometimes a fuller description is necessary but I try to avoid them due to the overall length of the name & the size of the space it displays. I personally prefer the terse names. |
This PR is complete. |
Summary
SUMMARY: Content "Adds fire station faction camp base option."
Purpose of change
Begin making faction camps more varied.
Describe the solution
Using the classic fire station for a test case.
Edit: at this point I think I've added all the base camp features except beds since they are linked to expansions. I'm considering having more beds build-able, but it would be just as easy for the player to use other options, same goes for storage.
EDIT:
Added NPC quarters area for more bedrooms, common area. Added skylights, and reduced chop shop to having a collection of tools/book.
Problems:
RESOLVED: Waiting on the spawning fix to get merged.
The dismantle for chop shop and the farming don't seem to work in the core building. I'm not sure if the radio is working either.
I've kept most constructions to the western area, and the back wall. It assumes you didn't come in and smash up all the furniture already (which may be a mistake), and uses that furniture or gives you materials for any that is 'disappeared'.
Finally, there is a fire truck in this base, but it blinks out of existence during update_mapgen. You need to approach it for it to reappear, which I forgot to do for the screenshot. Wonder woman would be envious.
Describe alternatives you've considered
Lots of other good buildings to choose from, but this was easily defensible and already has good space for the garage features.
Additional context
Posting this as a WIP/Draft to get some help troubleshooting initial spawn.
what it looks like finished:
The built out quarters. I've only offered normal white walls for now. The beds are full beds since mattresses should be common in the city.