Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fire station basecamp #34181

Merged
merged 12 commits into from Sep 30, 2019

Conversation

curstwist
Copy link
Contributor

@curstwist curstwist commented Sep 22, 2019

Summary

SUMMARY: Content "Adds fire station faction camp base option."

Purpose of change

Begin making faction camps more varied.

Describe the solution

Using the classic fire station for a test case.

Edit: at this point I think I've added all the base camp features except beds since they are linked to expansions. I'm considering having more beds build-able, but it would be just as easy for the player to use other options, same goes for storage.

EDIT:
Added NPC quarters area for more bedrooms, common area. Added skylights, and reduced chop shop to having a collection of tools/book.

Problems:
RESOLVED: Waiting on the spawning fix to get merged.
The dismantle for chop shop and the farming don't seem to work in the core building. I'm not sure if the radio is working either.

I've kept most constructions to the western area, and the back wall. It assumes you didn't come in and smash up all the furniture already (which may be a mistake), and uses that furniture or gives you materials for any that is 'disappeared'.

Finally, there is a fire truck in this base, but it blinks out of existence during update_mapgen. You need to approach it for it to reappear, which I forgot to do for the screenshot. Wonder woman would be envious.

Describe alternatives you've considered

Lots of other good buildings to choose from, but this was easily defensible and already has good space for the garage features.

Additional context

Posting this as a WIP/Draft to get some help troubleshooting initial spawn.

what it looks like finished:
firestation

The built out quarters. I've only offered normal white walls for now. The beds are full beds since mattresses should be common in the city.
quarters

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Map / Mapgen Overmap, Mapgen, Map extras, Map display Player Faction Base / Camp All about the player faction base/camp/site labels Sep 22, 2019
I think I got them all (except beds)
@mlangsdorf
Copy link
Contributor

It's awesome.

Some suggestions:

  1. possibly add skylights to make it easier to craft with the garage doors closed.
  2. move the garden 1 tile south and the radio tower 2 tiles south
  3. so that there can be an option to put up a privacy fence around the garden, running east from the north side of the annex and south along the yellow pavement to the central brick pillar.
  4. add pony walls on the east side to divide the vehicle bay into more housing instead of setting up a chop shop there - give the player the option to build either.
  5. possibly add an option to board up the north window but maybe that isn't necessary.

@curstwist curstwist marked this pull request as ready for review September 26, 2019 21:24
@curstwist curstwist changed the title [WIP] add firestation basecamp Add fire station basecamp Sep 26, 2019
Copy link
Contributor

@Night-Pryanik Night-Pryanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency. Please tidy up blueprint_name in all recipes - in some places it's full sentence, in other it's only just a name of location. Also consistency for upper case and lower case.

curstwist and others added 4 commits September 27, 2019 07:08
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
thanks, no more periods in names : )

Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
@curstwist
Copy link
Contributor Author

Consistency. Please tidy up blueprint_name in all recipes - in some places it's full sentence, in other it's only just a name of location. Also consistency for upper case and lower case.

Fixed the periods. I'll review their structure this evening. Sometimes a fuller description is necessary but I try to avoid them due to the overall length of the name & the size of the space it displays. I personally prefer the terse names.

@curstwist
Copy link
Contributor Author

This PR is complete.

@ZhilkinSerg ZhilkinSerg merged commit 3b54786 into CleverRaven:master Sep 30, 2019
@curstwist curstwist deleted the fire-station-faction-base branch September 30, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Player Faction Base / Camp All about the player faction base/camp/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants