Sort books in read menu #34266
Merged
Sort books in read menu #34266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BevapDin
reviewed
Sep 27, 2019
src/game_inventory.cpp
Outdated
| if( !book_a.skill && !book_b.skill ) { | ||
| return ( book_a.fun == book_b.fun ) ? base_sort : book_a.fun > book_b.fun; | ||
| } else if( !book_a.skill || !book_a.skill ) { | ||
| return book_a.skill ? true : false; |
There was a problem hiding this comment.
Suggested change
| return book_a.skill ? true : false; | |
| return book_a.skill.has_value(); |
There was a problem hiding this comment.
Hmm, doesn't have has_value() which seems to be a cata::optional thing but i get back a string_id<>.
Possible alternatives:
!book_a.skill.is_null()
!!book_a.skill
There was a problem hiding this comment.
Stupid null ids. Use !book_a.skill.is_null() in that case.
There was a problem hiding this comment.
I settled for static_cast() which uses the skill_id operator just in case.
BevapDin
reviewed
Sep 27, 2019
ZhilkinSerg
added
<Bugfix>
ZhilkinSerg
reviewed
Sep 27, 2019
ZhilkinSerg
reviewed
Dec 3, 2019
|
|
||
| if( !book_a.skill && !book_b.skill ) { | ||
| return ( book_a.fun == book_b.fun ) ? base_sort : book_a.fun > book_b.fun; | ||
| } else if( !book_a.skill || !book_a.skill ) { |
There was a problem hiding this comment.
Isn't there an error?
Suggested change
| } else if( !book_a.skill || !book_a.skill ) { | |
| } else if( !book_a.skill || !book_b.skill ) { |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Sort books in read menu"Purpose of change
Fixes #33555
Additional context