Move morale and related functions to Character #34911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
added
[C++]
ifreund
force-pushed
the
morale-to-character
branch
from
a1de463
to
f0e1e1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Move morale and related functions to Character."
Purpose of change
Progress in #34721
Describe the solution
Move the morale pimpl and most of the related functions to
Character.Leave
apply_wetness_morale()in player for now as it depends on moving a lot of other stuff first.Testing
Should be no visible changes from this PR, confirmed that the game compiles and starts up, didn't notice anything weird with morale.
Additional context
Depends on #34910