Fix issue with foods not inheriting anything during canning

[Davi-DeGanne]

Summary

SUMMARY: Bugfixes "Fix issue with foods not inheriting anything during canning"

Purpose of change

Fixes #32564
Fixes other bugs as well (see below).

Describe the solution

The crafting finalization process was attempting to perform the following operations on the can/jar/container rather than the food contained within:

• Flag inheritance
• Poison inheritance
• Assigning components (which governs kcal/vitamin inheritance)
• Rot carryover
• Temperature assignment

So all these systems weren't working when crafting contained food. I changed it so that when the crafted item is a non-empty container, the contents undergo these operations rather than the container.

Testing

Craft soup twice with identical ingredients, except craft one canned, and the other not. They should have identical vitamins and calories.
I tested it myself with a few different recipes and it seems to work.

[Davi-DeGanne]

A note for code reviewers:

For some reason, I don't like that I used a pointer here (though granted, that's most likely because I'm still not very experienced with using them so they scare me). Was there a good way to get content_ptr as a reference rather than a pointer? And would that have been a better solution for any reason? Or am I overthinking this and it's fine as is?

[esotericist]

A note for code reviewers:

For some reason, I don't like that I used a pointer here (though granted, that's most likely because I'm still not very experienced with using them so they scare me). Was there a good way to get content_ptr as a reference rather than a pointer? And would that have been a better solution for any reason? Or am I overthinking this and it's fine as is?

A pointer to an object is implicitly a reference to that object.

[Davi-DeGanne]

A pointer to an object is implicitly a reference to that object.

Hmm I worded my question poorly due to lack of knowledge of the nomenclature. I guess I meant, is there any way to end up with

item &content;

instead of

 item *content_ptr;

and is it preferable for any reason?