Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add photophore mutations #35223

Merged
merged 13 commits into from
Nov 5, 2019
Merged

Add photophore mutations #35223

merged 13 commits into from
Nov 5, 2019

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Nov 1, 2019

Summary

SUMMARY: Content "Add bioluminescence mutations"

Purpose of change

Weak Photophore: A photophore protudes from your head and can glow like a glowstick for about 9kcal/224h
Photophore: your photophore can glow like the flashlight app of a phone for about 9kcal/112h

Describe the solution

Move active_light()to character ( #34721)
Add lumination property to mutations, lumination is a map of bodyparts and intensity
Check for lumination from mutations in active_light()
Check for coverage of affected body part()
Coverage reduces light emited by the mutation

Describe alternatives you've considered

Testing

Lab patient start with biolum trait
Turn on
Glow
Loose kcal
Start again with the oter trait
Glow more consume more kcal
Put on a hat -> no light
image
Drop hat -> light
image

Additional context

Once I move activate_mutation() to Character I'll probably change BIOLUM1 to either tun on randomly or turn on when the Character mood is high enough, making it a negative trait instead.

The initial idea for this trait comes from https://www.reddit.com/r/cataclysmdda/comments/dpneee/bioluminescence/

@irwiss
Copy link
Contributor

irwiss commented Nov 1, 2019

The kcal values are weird, is it a 1kW flashlight? Where does all the heat dissipate to?

@Zireael07
Copy link
Contributor

It's not literally a flashlight, it gives off the amount of light equal to it.

@curstwist curstwist added [C++] Changes (can be) made in C++. Previously named `Code` Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON labels Nov 1, 2019
@Fris0uman Fris0uman changed the title Add bioluminescence mutations [WIP]Add bioluminescence mutations Nov 1, 2019
@Fris0uman Fris0uman changed the title [WIP]Add bioluminescence mutations Add bioluminescence mutations Nov 1, 2019
Co-Authored-By: matskuman5 <selinmatias5@gmail.com>
@Amoebka
Copy link
Contributor

Amoebka commented Nov 2, 2019

Incandescent light bulbs have energy effiency of about 5% (i.e. 5% of used energy is converted into visible light). Chemical bioluminescence is about 96% efficient.

So no, the mutation should most certainly NOT consume as much energy as a flashlight to produce the same amount of light, it should consume about 20 times less.

@Fris0uman
Copy link
Contributor Author

Considering the light has to go through the upper skin layer, your cloth ,and is produced all over your entire body to get those level of light it consume a bit more energy that a purpose build lamp.

Still the current values are not that high.

@Amoebka
Copy link
Contributor

Amoebka commented Nov 2, 2019

Considering the light has to go through the upper skin layer

Why? If the intention is to mimic bioluminescence of real life animals like fireflies, realistic mechanisms and therefore numbers should be used.

You also run into the aforementioned heat issue. If the mutation consumes the same amount of energy as a flashlight and produces the same amount of light, the same 95% of energy have to be converted into heat, it can't disappear into nothing.

If you call it BIOluminescense it should actually take biology into consideration. The current number is way outside of believable ranges.

@Fris0uman
Copy link
Contributor Author

It would be very helpful if you could provide proper numbers.

@Amoebka
Copy link
Contributor

Amoebka commented Nov 2, 2019

See above. 20 times lower than a flashlight of similar light output.
Assuming standart flashlight to be 1-2 watts, that means 0.04-0.08 kcal/hour.

Edit: since an average human body burns ~100 kcal/hour just doing usual human things, one has to wonder if this extra burn is even noticeable enough to include.

@Fris0uman Fris0uman changed the title Add bioluminescence mutations [WIP] Add bioluminescence mutations Nov 2, 2019
@Fris0uman Fris0uman changed the title [WIP] Add bioluminescence mutations Add photophore mutations Nov 2, 2019
@kevingranade kevingranade merged commit e2c3b78 into CleverRaven:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants