refactor drop activity and associated functions #36205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[C++]
KorGgenT
force-pushed
the
refactor-drop
branch
from
ebd4067
to
d814e65
Compare
KorGgenT
force-pushed
the
refactor-drop
branch
from
d814e65
to
9a72a1d
Compare
BevapDin
reviewed
Jan 2, 2020
| } ); | ||
|
|
||
| if( iter == worn.end() ) { | ||
| // TODO: Use a calculated cost | ||
| worn.emplace_front( dit, dit->count(), 100 ); | ||
| const item_location loc( p, dit ); | ||
| act_item act( loc, loc->count(), loc.obtain_cost( p, loc->count() ) ); |
There was a problem hiding this comment.
This lines seems to have no effect. It creates an act_item object named act, but that object is never used. It's constructor does not have side effects and the functions called to obtain the parameters also have no side effects.
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "refactor drop activity and associated functions"Purpose of change
This is the largest portion of the refactoring of game::inventory_item_menu, in order to convert usage to item_location from
int posDescribe the solution
This was a bit of a rabbithole: i started by changing the drop functions. that led me to the drop activities, and then finally the inventory selectors for dropping. It cause me to change the player member of the inventory selectro from const, and there is at least 1 const_cast from item * in order to be able to utilize it in an item_location. the const_cast is supposed to be temporary, and refactored again, but that would likely be even more refactoring.
I have also tried to kill
autoin any areas that were near the code i touched.Testing
dropped various items, multidrop and regular drop.
Additional context