Mr Lapin NPC Warrener #36287
Merged
Mr Lapin NPC Warrener #36287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mission change in npc as well
curstwist
added
[JSON]
learning new ways to mark entries
|
|
I-am-Erk
requested changes
Jan 5, 2020
I think I've found them all since they should have just been in the Mr_Lapin.json? |
I-am-Erk
requested changes
Jan 5, 2020
Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Consolidating to the holdouts npc file.
|
I'm seeing a bunch of errors that I'm pretty certain aren't related to my changes? |
|
Yeah I'm not concerned about that but I do still want to see the class definition moved to mr_lapin.json |
Just saw where my commits from this morning hadn't gone up because I hadn't fetched down changes from the remote. Sorry bout that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "NPC Rabbit Raiser"
Purpose of change
Rabbits are fast and should be hard for players to tame on their own. This NPC will make that task a little bit easier.
Describe the solution
Creates a cabin with a rabbit hutch behind it. This hutch will usually load with rabbits and sometimes with an NPC questgiver who will make it easier to get live rabbits from the hutch.
Describe alternatives you've considered
I want to try and get this in and then examine how I can utilize nested mapgen chunks to make this more random than just loading a specific cabin with a chance to load the NPC. Nesting will also allow a reduction in lines I believe.
Testing
Tested spawn, missions and dialogue.
Additional context