Add "repairs_like" for items without a recipe #36700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BevapDin
reviewed
Jan 4, 2020
When items did not have a recipe, the difficulty for repairing them was set to 10. For some items, such as scarves, this made repairing the activated versions of them much more difficult than repairing the non-activated versions. Now, they can have a 'repairs_like' specified, and if they do not have a recipe, they will use the recipe of that item instead.
anothersimulacrum
force-pushed
the
scarf
branch
from
8c5756a
to
f679174
Compare
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix items without a recipe having very high recipe difficulty"
Purpose of change
Fixes #36580
Describe the solution
Add
repairs_liketo itype, and modifyrepair_item_actor::repair_recipe_difficulty()to use the item'srepairs_likeif a recipe for the item is not found.Add
find_repair_difficulty(), which finds the appropriate repair difficulty for the itype_id provided, and use this to reduce code duplication inrepair_item_actor::repair_recipe_difficulty().Testing
Create a character, spawn in a scarf, sewing kit, and several rags. Attempt to reinforce the scarf, and note the difficulty.
Activate the scarf to loosen it, then attempt to reinforce it, and note that the difficulty is the same.
Additional context
I may be missing some items that could use
repairs_like.