Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop ant tunnels stomping over other map terrain underground and removing staircases #36702

Merged
merged 3 commits into from Jan 5, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 4, 2020

Summary

SUMMARY: Bugfixes "Stop ant tunnels stomping over other map terrain underground and removing staircases"

Purpose of change

Fixes #27195

Describe the solution

As per ralreegorganons comment on linked issue, adde da check for solid rock terrain before allowing ant tunnel to be placed, this would stop it replacing map specials that need to retain their staircases.

Describe alternatives you've considered

N/A

Testing

found an intersecting subway/anthill, and the subway retained its staircase going up.

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jan 4, 2020
@kevingranade kevingranade merged commit ada2433 into CleverRaven:master Jan 5, 2020
@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 5, 2020

so just like, fix a year-old release blocker and a bug as old as anthills in a couple hours with five lines of code, why dontcha.

@ghost
Copy link
Author

ghost commented Jan 5, 2020

so just like, fix a year-old release blocker and a bug as old as anthills in a couple hours with five lines of code, why dontcha.

Turns out I didnt really :P Infact I made it worse, thats what I get for working on an area I really dont understand and botching it because I thought it was a real simple fix :P

@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 6, 2020

I saw. You monster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anthill generation can overwrite parts of OMT specials, removing stair destinations
3 participants