Fix Travis build failure overmap test #36728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update forked repo
Update forked repo
Update forked repo
BevapDin
reviewed
Jan 5, 2020
src/overmap.cpp
Outdated
| @@ -3174,9 +3174,6 @@ void overmap::build_anthill( const tripoint &p, int s ) | |||
| } | |||
| } | |||
| } | |||
| if( queenpoints.empty() ) { | |||
| debugmsg( "No queenpoints when building anthill" ); | |||
| } | |||
| const tripoint target = random_entry( queenpoints ); | |||
There was a problem hiding this comment.
random_entry will return a default constructed value, in that case (0,0,0) - so the queen chamber will always be at that point within each overmap - irregardless of the location of the anthill.
It would probably be best to skip setting the terrain "ants_queen" in that case.
8street
changed the title
|
Test passed: |
|
This is reporting an actual bug, that PR actually broke anthill generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix travis build overmap failure tests"Purpose of change
Due to PR #36702 now sometimes an anthill is not created. An debug message is generated that failed overmap test.
Describe the solution
Deleted a useless message. If there is no anthill, the game will not be crashed anyway.
Describe alternatives you've considered
Testing
Test passed:
default_overmap_generation_always_succeedsAdditional context