change scope of some player member functions

[KorGgenT]

Summary

SUMMARY: Infrastructure "change scope of some player member functions"

Purpose of change

part of #34721
I changed the scope of the following player:: member functions to Character::

• pos()
• sight_range()
  note: changed return to use clamp instead of std::min(std::max())
• unimpaired_range()
• overmap_los()
• overmap_sight_range()
• clairvoyance()
• sight_impaired()
• has_alarm_clock()
• has_watch()
• action_taken()
• is_on_ground()
• swim_speed()

and the following function from player:: to Creature::

• is_underwater()

Testing

Compiled, ran the game for a few turns. I expect this is actually a really safe change.

Additional context

No reason to rush it, even though i think it's safe some of my other PRs have made some bugs and we're closing in on 0.E

[lgtm-com]

This pull request introduces 1 alert and fixes 1 when merging cd90032 into db5ba71 - view on LGTM.com

new alerts:

• 1 for Multiplication result converted to larger type

fixed alerts:

• 1 for Multiplication result converted to larger type

[ZhilkinSerg]

You did not move that check, so it can cause DBZ now.