Add option to change position of look around windows #36804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds UI function in options to change look around window between left and right
|
Please run your changes through the astyle. |
|
Yeah, my fault. When I was following the compiling guide, I didn't realize the astyle test was off. As a non-programmer, I'm not familiar with the concept and was already learning what it is and looking through the files. |
8street
reviewed
Jan 9, 2020
la window is defined on right-hand side, and cleanup conditional
ZhilkinSerg
added
[C++]
|
@kevingranade: New option suggested |
Fix la window always redisplaying on right side when toggling minimap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Add option to change position of look around windows"Purpose of change
First part of my own request #36327.
Describe the solution
Adds "Look around position" in the interface options, where the options are left and right (right is default).
Describe alternatives you've considered
Do nothing and wait for someone else to do it.
Testing
Play the game with sidebar on right and look around window on right.
Play game with sidebar on right and look around window on left.
Play with sidebar on left and look around window on right.
With sidebar on left and look around window on left.
Tested on bordeless fullscreen, maximized and windowed.
Additional context
See original issue for screenshots of how it looks now.
Used the pickup position code as reference.
Will add options for the aim window and list items window as separate PRs if nothing goes terribly wrong with this one.