Make int_id::operator int explicit
#37387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BevapDin
reviewed
Jan 26, 2020
| @@ -222,7 +222,7 @@ void editmap_hilight::draw( editmap &em, bool update ) | |||
| char t_sym = terrain.symbol(); | |||
| nc_color t_col = terrain.color(); | |||
|
|
|||
| if( g->m.furn( p ) > 0 ) { | |||
| if( g->m.furn( p ).to_i() > 0 ) { | |||
There was a problem hiding this comment.
We really need a is_null function in int_id.
There was a problem hiding this comment.
I fully agree, but that should perhaps come in a separate PR.
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Make
int_id::operator intexplicit for better type safetyTesting
It compiles.
Additional context
This also revealed a bug in mapgen where terrain ids were used as randomization range, perhaps a relic from before the JSON era. Since int ids now depend on the loading order of JSON files, it could cause weird terrain tiles to be generated. Fixed by randomizing from a list of actually intended terrain ids.