Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sus bathroom 3.5 #37431

Merged
merged 9 commits into from
Mar 10, 2020
Merged

Conversation

xanderrootslayer
Copy link
Contributor

Summary

SUMMARY: Content "updates to domestic.json item groups"

Purpose of change

As a step to add verisimilitude to residential houses, greatly expand item groups to include common consumable medicines and first aid supplies.

Describe the solution

Because the new Single Use Storage groups take priority over the classic item groups, the healing items the player character is probably searching for have been added to the SUS groups.

Describe alternatives you've considered

Applying these new item groups will take careful consideration of placement- and even besides that, classic item groups may still be useful.

Testing

Booted up the game and toured some houses.

Additional context

xanderrootslayer and others added 6 commits December 29, 2019 21:14
Wait, these are my own PRs
for 3.5 we will be doing just this file and nothing else.
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact Spawn Creatures, items, vehicles, locations appearing on map labels Jan 27, 2020
@I-am-Erk
Copy link
Member

Did you mean to adjust pantry rates in this as well, or did you get a stray commit?

@xanderrootslayer
Copy link
Contributor Author

Did you mean to adjust pantry rates in this as well, or did you get a stray commit?

I... never even touched that group. How did that happen?

@I-am-Erk
Copy link
Member

So when I said to leave out the nested mapgen stuff, you could still put this into a few maps. Just don't add a whole pile of nested maps too, find a few houses with a non-variable bathroom and add some SUS to them as part of the PR. We're in content freeze anyway.

I edited out your changes. You probably have some changes on your master fork.

@ZhilkinSerg ZhilkinSerg changed the base branch from master to dev March 10, 2020 09:12
@ZhilkinSerg ZhilkinSerg merged commit aa39539 into CleverRaven:dev Mar 10, 2020
@ZhilkinSerg ZhilkinSerg mentioned this pull request Mar 10, 2020
13 tasks
ZhilkinSerg pushed a commit that referenced this pull request Mar 10, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 15, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 15, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 16, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 17, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 17, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 18, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 29, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 1, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 1, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 2, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants