Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Mutant npcs to aftershock #37530

Merged
merged 7 commits into from
Mar 6, 2020

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Jan 29, 2020

Summary

SUMMARY: Mods "Mutant NPCs to Aftershock"

Purpose of change

Aftershock is a world that is teetering between cyberpunk and post-cyberpunk, Genetic modification, cybernetic modification and uplifted animals are much more common than the base world. Some mutants will be from blob interactions, some will be from genesplicing, military and civilian experiments, some will be uplifted animals or designed beings that were never human to begin with. This is a start. This folder will also eventually have cybernetic NPCs as well.

Describe the solution

Move the Mutant NPCs mod files into Aftershock. Then make changes as needed.

Describe alternatives you've considered

Rewriting all this work.

Testing

Tested in new world creation, mutant NPCs spawn. Tested in existing world save with Mutant NPCs enabled from prior to obsoletion, no errors and mutant NPCs continue to load.

Additional context

@Maleclypse Maleclypse changed the title WIP [Aftershock] Mutant npcs to aftershock [Aftershock] Mutant npcs to aftershock Jan 30, 2020
Copy link
Member Author

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless anyone sees any problems that wouldn't have been caught in my testing method, this can be merged, I think.

@ZhilkinSerg ZhilkinSerg added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod labels Jan 30, 2020
@I-am-Erk
Copy link
Member

One of the previous issues with mutant NPCs was that it invalidates the npc backstory and appearance traits if it popped in. Don't know if that matters or not to you, or even if it's still happening

@Maleclypse
Copy link
Member Author

One of the previous issues with mutant NPCs was that it invalidates the npc backstory and appearance traits if it popped in. Don't know if that matters or not to you, or even if it's still happening

I'll test for that, and I'm assuming I'd be able to add the demographics and backstory values back to these NPCs?

@ZhilkinSerg ZhilkinSerg changed the base branch from master to dev March 6, 2020 10:28
@ZhilkinSerg ZhilkinSerg merged commit af71a29 into CleverRaven:dev Mar 6, 2020
@ZhilkinSerg ZhilkinSerg mentioned this pull request Mar 6, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants