add categorize toggle to inventory #40143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
Info / User Interface
|
|
msvc-full-features/enc_temp_folder/41d0c12c7c36ae135e7872bfb7afcaa8/inventory_ui.cpp
Outdated
Show resolved
Hide resolved
|
I hope this gets merged asap, UI clarity is a big deal |
|
One nit, the "old" way of displaying this should be the default, the new way of drawing the inventory is useful for shuffling items around, but the goal is for that to be rarely necessary. |
|
ah. i'll have to do some shuffling of the initialization of the menu then. |
KorGgenT
force-pushed
the
add-categorize-toggle-to-inventory
branch
from
b925e5e
to
3596c02
Compare
|
|
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Adds toggle key in inventory to show categorized items"Purpose of change
i've been hearing a lot from people about how they want the categorized view instead of everything being shown under what item it's contained in, so i added a toggle button in the main inventory screen.
Describe the solution
Adjusts the inventory columns when hitting the toggle so the own_inv-column is used, and adds it via add_entry so categories are applied. pressing the toggle again will put it back to how it was.
Testing
Have a decently sized inventory and press the toggle button.
Additional context
screenshots to follow when this comes out of draft.