Add flags to prevent modification of vehicle parts #40244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Prevent the hacky workarounds used to do this previously, such as in rotors.
Describe the solution
In
can_install_partandcan_remove_part, check if the vehicle part has theNO_INSTALL_PLAYERorNO_UNINSTALLflags respectively, and block installing or removing based on that.In
do_repair, bail out if the vehiclepart has theNO_REPAIRflag.Describe alternatives you've considered
There are some more things this could be added to.
Testing
Spawn in an apache helicopter.
Attempt to install rotors.
Attempt to uninstall existing rotors.
Debug strength to around 200, and attempt to smash rotors (this is roughly what is necessary). Do this until they are damaged, then attempt to repair them.
Additional context
Slightly out of date screenshots.