Add previously missing json-loading of desc_freq in music instruments #40253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As above
ZhilkinSerg
added
<Bugfix>
ZhilkinSerg
reviewed
May 6, 2020
RedShakespeare
changed the title
|
Have rewritten the pr description. |
fengjixuchui
added a commit
to fengjixuchui/Cataclysm-DDA
that referenced
this pull request
May 8, 2020
Merge pull request CleverRaven#40253 from RedShakespeare/music_instru…
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixes loading of desc_freq in music instruments"
Purpose of change
The attribute "description_frequency" in music_instrument didn't load from json files at all in the past versions, which made descriptions of playing the instruments never appear in game---Tried to fix this.
Describe the solution
The previous author seemed to forget the loading step before checking existence, so I add this step back.
Describe alternatives you've considered
No....?Actually I'm not quite sure whether the existence examination should remain there or not.
Testing
Should work in theory...