Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove several obsolete mods #40332

Merged
merged 2 commits into from
May 9, 2020

Conversation

anothersimulacrum
Copy link
Member

Summary

SUMMARY: None

Purpose of change

Remove obsolete mods. I figure it's been long enough that old saves won't be a problem, but I could be wrong.
List: NW pack, Mundane Zombies, RL classes, sleep deprivation, zombie nightvision, fast healing, makeshift, necromancy

Describe the solution

git rm -r obsolete mods

Describe alternatives you've considered

Waiting longer.
Adding the mods removed to the mod test blacklist. I decided against this to prevent merge conflicts, it can be done later.

@ymber
Copy link
Member

ymber commented May 8, 2020

Make sure you catch any dead code these mods had in the engine.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Organization General development organization issues labels May 8, 2020
@SirPendrak
Copy link
Contributor

Sleep deprivation should be mainline, not removed.

@anothersimulacrum
Copy link
Member Author

It has been mainlined, I'm removing the mod files that still existed for it.

@kevingranade kevingranade merged commit ed9f3b9 into CleverRaven:master May 9, 2020
@anothersimulacrum anothersimulacrum deleted the rm-mod5 branch May 9, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Organization General development organization issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants