Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable mouse input - rework #41605
Enable mouse input - rework #41605
Changes from all commits
70e6421
c992213
cb1274c
6ccdd8a
b912bd4
8078efb
100e60b
3206b68
3faa3eb
3815ec1
04e8f80
7dfb153
19a9fa5
ac5e177
e70471a
204e1c2
9315ac9
40cf710
046f864
4e95d88
a183e50
b1b76d9
4b0614c
e77ac21
1f15635
42d762b
88b9259
697a53e
dab79ec
30ab7e9
3b30934
a23f04e
11c9726
b358fec
7279394
b2a898e
7e8ffb2
02b3c31
04ff66a
5dee434
28da032
9d36050
87e9249
8128993
b5cd32e
cb5075c
18c6940
d6e527d
4462ffd
cfebf17
60ae6d1
7c79818
3bfb5a6
a7723cf
583f49f
14bbe4d
f352e8f
33d75f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested, but judging from the backtrace the crash might happen when you click on a category heading, which doesn't contain any items and would fail the assertion in
inventory_entry::any_item
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please test again? I think I've resolved the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot reproduce a SIGABRT.
But I cannot select items in inventory in this inv. view mode if I changed the view mode (
;
) before selecting them. Clicking items on the left side does nothing:I can select not worn items in another inv. view mode. But if I change view mode twice they are shown without the
+
sign.