Limited amount of splints in autodoc #47379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also print an error if there's not enough splints. Also fixed a bug where autodoc couldn't splint two broken arms or two broken legs simultaneously.
Night-Pryanik
added
<Enhancement / Feature>
Comment on lines
+4926
to
+4931
| if( supplies.typeId() == itype_arm_splint ) { | ||
| arm_splints.push_back( supplies ); | ||
| } | ||
| if( supplies.typeId() == itype_leg_splint ) { | ||
| leg_splints.push_back( supplies ); | ||
| } |
There was a problem hiding this comment.
Could I suggest a flag instead of a hardcoded id check?
There was a problem hiding this comment.
I thought about it, but as you stated below, it made using use_amount impossible, so I decided that hardcoded ids would be tolerable for now.
| int quantity = 1; | ||
| if( part == bodypart_id( "arm_l" ) || part == bodypart_id( "arm_r" ) ) { | ||
| if( arm_splints.size() > 0 ) { | ||
| for( const item &it : get_map().use_amount( examp, 1, itype_arm_splint, quantity ) ) { |
There was a problem hiding this comment.
Though using flags could make this tricky, so it's only a suggestion.
|
Would it be possible to reload them with splints? |
Yes. Autodoc now functions as container which allows it to hold items inside. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Limited amount of splints in autodoc."
Purpose of change
Unlimited splints in autodoc was neither realistic nor fun.
Describe the solution
Describe alternatives you've considered
None.
Testing
Debug-broken both of my character's arms and one leg. Put one arm splint and two leg splints in autodoc. Selected bonesetting in autodoc's menu. One broken arm and broken leg were splinted. Second attempt of bonesetting showed me an error.
Additional context
New list in autodoc's menu depicting available supplies
Two out of three broken limbs were splinted
Second attempt of bonesetting, when there's no available arm splints in autodoc, popped up an error
In order to fix the aforementioned bug, I had to slightly change the logic. Now autodoc forcefully splints the broken limb even if there's another splint set up already. But it's still a good thing as autodoc applies very good level of bonesetting, and your character level of recover for that limb will instantly be bumped to "Mostly recovered".