Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interface] sidebar-mobile #59422

Merged
merged 9 commits into from Jul 30, 2022
Merged

Conversation

vetall812
Copy link
Contributor

@vetall812 vetall812 commented Jul 19, 2022

Summary

Interface "sidebar for mobile users"

Purpose of change

Heavily modified sidebar. Mostly for mobile users that use Terminus font (shipped with the game).
Relies on the font (but some other fonts can be used too). Uses as less rows as possible, second guide is to be as compact as possible. Adds as much indicators as possible.

Describe the solution

Expected size of fixed data - 25 lines, 41 width.
Two main colors defined by t_border and t_label widget templates.
First letter of the widget defines it functionality (some widgets are like existing ones but with small quirks):

  • t - template
  • l - label
  • i - indicator
  • a - layout Arrangement
  • w - widget
  • r - sidebar Row
    Labels used only for sidebar rows.

Describe alternatives you've considered

Testing

default colors / dark scheme / vintage scheme
image

Additional context

TODO:

Heavily modified sidebar. Mostly for mobile users that use Terminus font (shipped with the game).
changed carry_weight variable back to text
added note to rearrange compass and MA layout
@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions labels Jul 19, 2022
some widget rearrangement
@mlange-42
Copy link
Contributor

change time to sundial if no WATCH weared

This can already be solved by the new text var sundial_time_text / widget sundial_time_desc_no_label:

"id": "sundial_time_desc_no_label",

@vetall812
Copy link
Contributor Author

change time to sundial if no WATCH weared

This can already be solved by the new text var sundial_time_text / widget sundial_time_desc_no_label:

"id": "sundial_time_desc_no_label",

Yeah, sundial widget exist. But it doesn't change to actual time if you have a watch on you.

@mlange-42
Copy link
Contributor

Yeah, sundial widget exist. But it doesn't change to actual time if you have a watch on you.

This one does (it is quite new and was introduced here: #59182). Check the "structured" sidebar.

Drop everything with WATCH:

grafik

Pick up wrist watch:

grafik

@vetall812
Copy link
Contributor Author

Yeah, sundial widget exist. But it doesn't change to actual time if you have a watch on you.

This one does (it is quite new and was introduced here: #59182). Check the "structured" sidebar.

Nice! Thank you!

removed unnecessary time widget, replaced by new sundial
added clause for moon phase - now visible only at night
Rearranged some indicators for bodyparts
Added ability to change HP graph widget to broken widget
Encumbrance widget can swap to splint indicator
Added 'mending', 'stunned', 'hypovolemia' indicators
Moon phase widget removed until padding is fixed
added bionic power meter and balance indicator
@vetall812
Copy link
Contributor Author

Well, it is ready to be published!

@vetall812 vetall812 marked this pull request as ready for review July 30, 2022 17:16
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 30, 2022
@bombasticSlacks bombasticSlacks merged commit 797b073 into CleverRaven:master Jul 30, 2022
alef pushed a commit to alef/Cataclysm-DDA that referenced this pull request Aug 6, 2022
* Create sidebar-mobile.json

Heavily modified sidebar. Mostly for mobile users that use Terminus font (shipped with the game).

* Update sidebar-mobile.json

changed carry_weight variable back to text
added note to rearrange compass and MA layout

* Update sidebar-mobile.json

some widget rearrangement

* Update sidebar-mobile.json

removed unnecessary time widget, replaced by new sundial

* Update sidebar-mobile.json

added clause for moon phase - now visible only at night

* Update sidebar-mobile.json

Rearranged some indicators for bodyparts
Added ability to change HP graph widget to broken widget
Encumbrance widget can swap to splint indicator
Added 'mending', 'stunned', 'hypovolemia' indicators
Moon phase widget removed until padding is fixed

* Update sidebar-mobile.json

added bionic power meter and balance indicator

* Update sidebar-mobile.json

* Update sidebar-mobile.json

linted
@vetall812 vetall812 deleted the sidebar-mobile branch August 29, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants