Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update COMPILING.md C++14 reference to C++17 #64724

Merged
merged 7 commits into from
Apr 5, 2023
Merged

Update COMPILING.md C++14 reference to C++17 #64724

merged 7 commits into from
Apr 5, 2023

Conversation

sonphantrung
Copy link
Contributor

Summary

None

Purpose of change

DDA now uses C++17, not C++14 anymore!

Describe the solution

Replace the text, simple as that

Describe alternatives you've considered

NONE

Testing

See my branch

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 31, 2023
@irwiss
Copy link
Contributor

irwiss commented Mar 31, 2023

imo just remove that section entirely and link to COMPILER_SUPPORT.md, there's no need to duplicate the info or give instuctions for checking std support

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 31, 2023
sonphantrung and others added 2 commits March 31, 2023 21:08
@sonphantrung @dseguin
Update doc/COMPILING/COMPILING.md
230d9ac 
Co-authored-by: David Seguin <davidseguin@live.ca>
@sonphantrung
Update the FBSD section
37762fd
@kevingranade
Copy link
Member

I think @irwiss is right, this section was reasonable for c++11 and c++14, but the process of adopting c++17 was more protracted and I'm pretty sure if you follow these instructions on gcc 5 it will indicate you're on a recent enough version but it will not work.

@kevingranade kevingranade merged commit 32e04e0 into CleverRaven:master Apr 5, 2023
Maleclypse pushed a commit to Maleclypse/Cataclysm-DDA that referenced this pull request Apr 6, 2023
@sonphantrung @dseguin @Maleclypse
Update COMPILING.md C++14 reference to C++17 (CleverRaven#64724)
e7088c9 
Co-authored-by: David Seguin <davidseguin@live.ca>
@sonphantrung sonphantrung deleted the update-for-compiling-md branch January 10, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettDong BrettDong BrettDong left review comments

@dseguin dseguin dseguin left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sonphantrung @irwiss @kevingranade @dseguin @BrettDong