Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add myself to CODEOWNERS for clang-tidy stuff #64790

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Add myself to CODEOWNERS for clang-tidy stuff #64790

merged 1 commit into from
Apr 2, 2023

Conversation

jbytheway
Copy link
Contributor

Summary

None

Purpose of change

I'd like to be notified for changes related to clang-tidy (and some other stuff in tools).

Describe the solution

Add myself to CODEOWNERS for those.

@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 2, 2023
@ZhilkinSerg ZhilkinSerg merged commit 03fe360 into CleverRaven:master Apr 2, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 2, 2023
@jbytheway jbytheway deleted the codeowners-clang-tidy branch April 3, 2023 00:46
@BrettDong
Copy link
Member

I believe your account has to be a member of the organisation for CODEOWNERS to work.

@anothersimulacrum
Copy link
Member

I think you specifically need write access to branches (e.g. more than just triage).

@ZhilkinSerg
Copy link
Contributor

@kevingranade should they be added to maintainers team in organization then?

@jbytheway
Copy link
Contributor Author

I did notice that it warned me about a lack of write access, but since there were several other people in the file without write access I figured it might work without it.

@NetSysFire
Copy link
Member

#56802

Maleclypse pushed a commit to Maleclypse/Cataclysm-DDA that referenced this pull request Apr 6, 2023
@jbytheway @Maleclypse
Add myself to CODEOWNERS for clang-tidy stuff (CleverRaven#64790)
dc05287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbytheway @BrettDong @anothersimulacrum @ZhilkinSerg @NetSysFire