Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

palettized fbmc radio tower #66574

Merged

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Use palette parameters to cut down on JSON volume for the fbmc radio tower base camp.

Bycatches:

  • Added makeshift bed to the set of beds.
  • Added concrete as a construction material.
  • Allowed all construction materials to be used to plug windows, not just wood and mi-go resin.

Describe the solution

  • Made use of the fbmc_modular_shack.json definitions for beds.
  • Made use of the same file definitions for construction materials.
  • Added palette parameterized single tile wall definition for use as chunk for plugging walls and used those for the wall plugging instead of explicit definition of specified wall segments at specified locations. This also resulted in the removal of the explicit materials requirements for the task, letting the normal requirements be used instead.

Describe alternatives you've considered

Change wall plugging to instead board up windows. Considered that to be out of scope.

Making it visible that there are actually two different building/bed construction sets, rather than a single big one (they're numbered up to 8, but the different base variants actually use different halves of that series). However, that would mess up existing base camps under construction, and would also be out of scope.

Testing

Teleported to both types of radio towers (with and without adjacent building) for testing.
Built "everything" in the first (building less) tower with concrete and straw beds. I failed to see what difference the first radio repair step did, and couldn't actually perform the second one as my spawning of the required software resulted in "misc software". Since the radio recipes are not touched, I didn't pursue this further. I've then constructed the log/normal bed combination of the base, without any of the common parts, followed by metal/makeshift bed, followed by each of the other construction materials. After each construction session the game was killed after inspection and a save at the beginning of the process was reloaded.
I've also teleported to the tower with a side building where I've done the full concrete/straw bed, log/normal bed, metal/makeshift beds, and then each of the other materials without beds.

Additional context

I tried to use the flag to dismantle furniture for beds replacing furniture, but it didn't work (i.e. had no additional effect), presumably because it deals with terrain construction. I also tried to add t_null, but it still didn't make a difference.
I also tried the same flag with the window->wall replacements, but, again, it did nothing, presumably because windows aren't furniture.

When it comes to the weird missing roofs I noted that in at least the building less tower roofs were present on the bottom half of the map, but not the top one. This suggests there might be something involving the loading of only a single map level when you actually need the one containing the roof as well.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 1, 2023
@dseguin dseguin merged commit e7aea19 into CleverRaven:master Jul 2, 2023
@PatrikLundell PatrikLundell deleted the fbmc_radio_tower_palettization branch July 2, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants