Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted random tritype usages to tripoint_bub_ms #71497

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

PatrikLundell
Copy link
Contributor

@PatrikLundell PatrikLundell commented Feb 4, 2024

Summary

None

Purpose of change

Perform an ant step along the path to use typed tripoints rather than untyped ones.

Describe the solution

  • Grab a random tritype/tritype_bub_ms pair of operations with a comment that the untyped one should eventually be removed.
  • Comment out the untyped one and see what breaks.
  • Grab some thing that doesn't compile and make it typed, spreading the typed/untyped commented operation pairs further by introduce typed versions of untyped operations to achieve the typing of the original failure.
  • Restore the operation originally commented out as the full conversion of affected code would be large.

Describe alternatives you've considered

Leave it to someone else, at a later time.

Testing

Compilation, plus start of the game. Can't really test the changes as that would require figuring out how those changes are used in the game to be able to test them.

Additional context

This is really a test shot. If merged (possibly after corrections as a result of comments), more can be done, and if rejected the considered alternative automatically kicks in.

If continued work in this direction is desired, it would be useful with suggestions on the order in which to tackle things both from a work load perspective (preparing things that other things rely on first, rather than in a haphazard fashion), and from a desirability perspective, i.e. which areas would be most useful to convert first.

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 4, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 4, 2024
@Maleclypse
Copy link
Member

@Procyonae have you worked in this area of the code before?

@Procyonae
Copy link
Contributor

@Procyonae have you worked in this area of the code before?

Not that I'm aware of why?

@Maleclypse Maleclypse merged commit 4802f8c into CleverRaven:master Feb 16, 2024
22 of 27 checks passed
@PatrikLundell PatrikLundell deleted the typify branch February 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants