Obsolete the obsoletion #71666
Merged
Obsolete the obsoletion #71666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
github-actions
bot
added
EOC: Effects On Condition
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @Night-Pryanik
github-actions
bot
added
astyled
GuardianDll
force-pushed
the
obsoletion
branch
from
76f7b8a
to
0cb6867
Compare
github-actions
bot
added
the
Code: Tests
GuardianDll
force-pushed
the
obsoletion
branch
3 times, most recently
from
4bd4b4b
to
745bb1b
Compare
github-actions
bot
added
the
Mods: Desert Region
GuardianDll
force-pushed
the
obsoletion
branch
from
745bb1b
to
a482f7a
Compare
github-actions
bot
added
Mods: Magiclysm
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @bombasticSlacks @Standing-Storm
GuardianDll
force-pushed
the
obsoletion
branch
from
a482f7a
to
0f0ef4d
Compare
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @Light-Wave
GuardianDll
force-pushed
the
obsoletion
branch
from
0f0ef4d
to
4910e4f
Compare
github-actions
bot
added
Mods: Dark Days of the Dead
GuardianDll
force-pushed
the
obsoletion
branch
from
4910e4f
to
2726bd6
Compare
github-actions
bot
added
the
BasicBuildPassed
GuardianDll
force-pushed
the
obsoletion
branch
from
2726bd6
to
d43da76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
0.H, despite not being released yet, was already separated from the master, so i consider it is an okayish time to clean up obsoletion folder
Describe the solution
Remove all files from obsoletion folder, reviewing it's elements step by step to not delete stuff, that should not be deleted in this release cycle (like stuff that was obsoleted after jan 4, when 0.H branch was created). Stuff that should wait was moved to
\obsoletion_and_migration_0.Ifolder.The only thing i didn't touch is prosthetics.json - it would be backported to the 0.H, but i decided it would be better to remove the file when it will actually happen
Remove items that was not migrated, migrate them - for mods i renamed this items so i could migrate the old IDs without intersections between vanilla migration of mod items
Fixed all errors, that was caused by removed items being still presented in our itemgroups - apparently our migration tool works way better that i ever expected
Replaced old note in json_info.md and mutation.md to a proper obsoletion_and_migration.md document, that describe how to migrate each type i removed here, but i'd like to hear some opinions to specify some stuff
Testing
Game loads and seems to work fine, let's see what tests say
Additional context
I am good to wait with this PR until 0.H would actually be released, if it's needed