Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility Tool Additions #71821

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

RanikOrtega
Copy link
Contributor

Summary

Content "New Utility Tools"

Purpose of change

Multi-Tools and folding knives are a dime a dozen. But real life examples of specialized multi-tools for camping exist and should be made available in game.

Describe the solution

Created a "Camping" Multitool and Utility folding knife.

Describe alternatives you've considered

Testing

Debug spawned items and confirmed their functions were working. Then teleported around and until I found an instance of the item spawned naturally.
Utility Knife
Camping multitool

Additional context

Real life references to "Deluxe" multitools:
https://www.leatherman.com/signal-832262.html
https://www.leatherman.com/free-k4x-591.html

Initial Items and their inclusion into item groups.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 18, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A 'Hideman' brand multi-tool. This model includes extra options for outdoors use such as a firestarting rod, awl, rescue whistle and a hammering surface.
  • camping multitools

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 18, 2024
@RanikOrtega
Copy link
Contributor Author

Ready for review and to Merge I believe. Only failed test is Ubuntu and even it says that it had no errors.

@BlizzDA
Copy link
Contributor

BlizzDA commented Feb 19, 2024

Changing the name to something legally distinct isn't required, looking at the description. Just if you wanted to call it an actual 'Leatherman' brand tool. We have games, books, guns and medicine named that way etc.

@RanikOrtega
Copy link
Contributor Author

RanikOrtega commented Feb 20, 2024

Changing the name to something legally distinct isn't required, looking at the description. Just if you wanted to call it an actual 'Leatherman' brand tool. We have games, books, guns and medicine named that way etc.

I like my puns. 😄 And just felt like it would be safer as " Hideman"

But if it's felt it would be better as the real life brand then I can change it to Leatherman.

@Maleclypse Maleclypse merged commit d6b054c into CleverRaven:master Feb 21, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants