Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutations list selector starts in the active column #71824

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

gtim
Copy link
Contributor

@gtim gtim commented Feb 18, 2024

Summary

Interface "Mutations list selector starts in the active column"

Purpose of change

Start the selector in the mutations list in the active column, since activating/deactivating mutations is the most common reason to enter the menu. Fixes #69106.

Describe the solution

Describe alternatives you've considered

Swapping positions of the active and passive columns.

Testing

Tested in-game, with and without active mutations.

Additional context

image

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 18, 2024
@ashGlaw
Copy link
Contributor

ashGlaw commented Feb 18, 2024

A good ui improvement 👍

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 19, 2024
@Maleclypse Maleclypse merged commit 3535ff7 into CleverRaven:master Feb 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have the "View/activate mutation" selector start in the active column
3 participants