Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update map::place_spawns() to use std::optional<std::string> for monster name #71861

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

Describe the solution

Update map::place_spawns() that I missed in #71846.

Describe alternatives you've considered

Testing

Start a new game and look at the names of the monsters spawned.

Additional context

@github-actions github-actions bot added Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 20, 2024
@ZhilkinSerg ZhilkinSerg merged commit 805c122 into CleverRaven:master Feb 20, 2024
28 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 20, 2024
@BrettDong BrettDong deleted the place-spawns branch February 20, 2024 10:59
@BrettDong BrettDong added the 0.H Backport PR to backport to the 0.H stable release canddiate label Feb 20, 2024
Procyonae pushed a commit to Procyonae/Cataclysm-DDA that referenced this pull request May 19, 2024
dseguin added a commit that referenced this pull request May 19, 2024
@Procyonae Procyonae added 0.H Backported and removed 0.H Backport PR to backport to the 0.H stable release canddiate labels May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.H Backported astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some monsters and animals have a name of NONE
3 participants