Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pillboxes #72261

Merged
merged 7 commits into from
Mar 24, 2024
Merged

Added pillboxes #72261

merged 7 commits into from
Mar 24, 2024

Conversation

tmqCypher
Copy link
Contributor

Summary

None

Purpose of change

CDDA doesn't have those weekly pill organizers that you might expect to find in drug stores, bathrooms, hotels, etc., and it would be convenient to have an item with smaller pockets than are currently available.

Describe the solution

I measured a couple pillboxes that I have at home (a simple weekly one and a bulkier bi-weekly one) for size/capacity/weight, verified that they would be sane compared to various in-game drugs, and added them to the JSON.

Describe alternatives you've considered

Not having pillboxes, but why would you want that?

Testing

I used the debug menu to spawn the pillboxes/test their item groups.

Additional context

The drugs in the pillbox_contents item group are meant to be daily supplements and, more rarely, prescription medications that a person would take every day. Most of the prescription items mutually exclude one another to avoid spawning with too many valuable pills and affecting the balance/availability of drugs.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Items: Containers Things that hold other things new contributor labels Mar 9, 2024
…json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 9, 2024
@Maleclypse
Copy link
Member

The pillbox pockets are to small to fit calcium tablets, anti fungal sand some other items in the itemgroup spawning them. It may mean those items are larger than they should be. Or you have too many spawning in a pocket.

@tmqCypher
Copy link
Contributor Author

The pillbox pockets are to small to fit calcium tablets, anti fungal sand some other items in the itemgroup spawning them. It may mean those items are larger than they should be. Or you have too many spawning in a pocket.

Thanks for catching that, I miscounted the total possible volume of the pillbox_contents group. Moving the calcium tablets into the vitamins/gummy vitamins distribution brought it back down to the maximum of 140 ml.

@Maleclypse
Copy link
Member

The pillbox pockets are to small to fit calcium tablets, anti fungal sand some other items in the itemgroup spawning them. It may mean those items are larger than they should be. Or you have too many spawning in a pocket.

Thanks for catching that, I miscounted the total possible volume of the pillbox_contents group. Moving the calcium tablets into the vitamins/gummy vitamins distribution brought it back down to the maximum of 140 ml.

Sorry this fell off my radar. I've kicked the tests and hopefully everything will pass.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 24, 2024
@Maleclypse Maleclypse merged commit 6c8db43 into CleverRaven:master Mar 24, 2024
19 of 24 checks passed
@tmqCypher tmqCypher deleted the pillbox_json branch April 24, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants