Enchantments forever #72328
Merged
Enchantments forever #72328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with SHOUT_NOISE
…lue replicates the effect of it
Co-authored-by: andrei <68240139+andrei8l@users.noreply.github.com>
…infrastructure for mutation that is not used anymore
…ing healing_awake
TODO: verify should i convert legacy int unit to temperature unit in json
github-actions
bot
added
<Documentation>
github-actions
bot
added
Mutations / Traits / Professions/ Hobbies
github-actions
bot
added
[Markdown]
github-actions
bot
added
Mods: Aftershock
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @Fris0uman @Standing-Storm @andrei8l
github-actions
bot
added
the
astyled
github-actions
bot
added
the
json-styled
KorGgenT
reviewed
Mar 12, 2024
Co-authored-by: Curtis Merrill <curtis.r.merrill@gmail.com>
github-actions
bot
added
the
BasicBuildPassed
Fris0uman
reviewed
Mar 12, 2024
github-actions
bot
added
Bionics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Continuation of #72173
Describe the solution
See the commit history
Testing
Compiled, didn't segfaulted, applied bunch of traits, the effects still as they described
Additional context
My only concern is bodytemp_sleep - it seems there was conversion between old int value and new, delta_kelvin; i am not sure should i convert the mutation value as
from_legacy_bodypart_temp_deltasuggests, 500 int to 1 degree (which result in miniscule 0.15 centigrade bonus for fur mutation) or not (which result in 75 degree bonus for fur)