Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Add EoC activity check for stopping learning power meditation #72352

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

Standing-Storm
Copy link
Contributor

Summary

Bugfixes "[MoM] Add EoC activity check for stopping learning power meditation"

Purpose of change

Because there's no u_has_activity condition, I have to use other safeguards and workarounds to make sure people don't start the meditation to learn powers, stop them and run off to do other things, and still get their powers anyway. It looks like it was still happening, so time to add another safeguard.

Describe the solution

Use a character_finishes_activity EoC to check if the meditation was manually interrupted and remove the effect that the success/fail EoC relies on to fire, preventing it from activating.

Describe alternatives you've considered

Testing

Interrupted meditation, effect successfully removed.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Mind Over Matter <Bugfix> This is a fix for a bug (or closes open issue) labels Mar 13, 2024
Standing-Storm and others added 2 commits March 12, 2024 19:57
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 13, 2024
@akrieger akrieger merged commit be1685d into CleverRaven:master Mar 22, 2024
20 of 24 checks passed
@Standing-Storm Standing-Storm deleted the fix-incorrect-learning branch March 22, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants