Make ImGui popup respond properly to 'h' and 'l' keys when highlighting selected option #72619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
katemonster33
force-pushed
the
imgui_popup_navigation_broken
branch
2 times, most recently
from
8370298
to
aad96d2
Compare
…g button focus back and forth.
katemonster33
force-pushed
the
imgui_popup_navigation_broken
branch
from
aad96d2
to
22b6624
Compare
github-actions
bot
added
the
BasicBuildPassed
SurFlurer
added a commit
to SurFlurer/Cataclysm-DDA
that referenced
this pull request
Aug 26, 2024
…en moving button focus back and forth. (CleverRaven#72619)" This reverts commit e746932.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixed issue where user could only change the selected option in the ImGui popup using the arrow keys or tab key"
Purpose of change
Fixes: #72599
Fixes: #72093
Describe the solution
ImGui popup was relying on ImGui's keyboard navigation, but because this isn't based on CDDA's keybindings, it leads to confusing situations where the bound keys don't work to, for instance, change the focused button in the popup.
Describe alternatives you've considered
We could try and implement some infrastructure for tying ImGui's input handling to Cataclysm's own input system, but that would require lots of sleepless nights.
Testing
From the main menu, delete a world, and verify that the correct buttons work to select the option in the popup, without buttons like tab changing the focus unexpectedly
Additional context